Experiment with using only two CircleCi images#7818
Experiment with using only two CircleCi images#7818WalterBright merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Thanks a lot for merging this @WalterBright - unfortunately I hit the bed before seeing the result here:
So it doesn't look good. (We recently #7711 disabled the display of the overall project coverage change as it (1) the backend has too much global state (i.e. random coverage state) too be informative and (2) it's not relevant to reviewers typically when they look at the diff. The important bit is that the diff is covered and the overall coverage changes are only in a few exceptions (like this one) interesting to look at, but then can be easily accessed by simply clicking on the CodeCov "Details" link in the CI status overview.) |
3 participants
Follow-up to #7420
In #7420 we added the
-fPICrun as a new imageas CodeCov was heavily complaining, this simply tests whether this is still the case.
In other words: this PR removes the no-pie x86_64 CircleCi image as in theory x86_32 + x86_64 in pie should cover almost everything that is covered by the three of them.